Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to Fortress for Rolling (future Humble) #195

Merged
merged 4 commits into from
Dec 30, 2021
Merged

Default to Fortress for Rolling (future Humble) #195

merged 4 commits into from
Dec 30, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Dec 24, 2021 •
edited
Loading

🎉 New feature

Summary

I'm not sure why I'm not being able to push to @doisyg's branch directly, so I'm opening a new PR with some extra changes and fixes.

Test it

Let's see what CI says.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Guillaume dev PC and others added 2 commits October 28, 2021 15:48
default to Fortress
19c49df 
Signed-off-by: Guillaume Doisy <[email protected]>
@chapulina
More updates for Fortress
11a1cfd 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Dec 24, 2021
Closed
@chapulina chapulina added needs upstream release Blocked by a release of an upstream library ROS 2 ROS 2 labels Dec 24, 2021
@chapulina chapulina mentioned this pull request Dec 28, 2021
Merged
@chapulina
merged from ros2
62b8ea3 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Dec 29, 2021
Closed
11 tasks
@chapulina
Remove Galactic and Citadel
4430384 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Dec 30, 2021
@chapulina chapulina merged commit 5327fea into ros2 Dec 30, 2021
@chapulina chapulina deleted the default_to_fortress branch December 30, 2021 19:18
@chapulina chapulina mentioned this pull request Dec 30, 2021
Closed
vatanaksoytezer pushed a commit to vatanaksoytezer/ros_ign that referenced this pull request Jan 18, 2022
Default to Fortress for Rolling (future Humble) (gazebosim#195)
84a2aee 
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Guillaume dev PC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @ahcorde