Backport the python3 embedSdf script variant #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These won't be used as part of the cmake build on this branch, but are useful for generating the same file from bazel. Co-authored-by: Bi0T1N <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
azeey
approved these changes
Feb 16, 2023
Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1240 +/- ##
==========================================
+ Coverage 87.49% 87.51% +0.01%
==========================================
Files 126 126
Lines 16239 16239
==========================================
+ Hits 14209 14211 +2
+ Misses 2030 2028 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@osrf-jenkins retest this please |
Merged
scpeters
reviewed
Jul 19, 2023
sdf/embedSdf.py
Outdated
| files = [] | ||
| for path in arg_pathlist: | ||
| # dir separator is hardcoded to '/' in C++ mapping | ||
| posix_path = PurePosixPath(path) |
There was a problem hiding this comment.
we've seen regressions on windows when porting this forward in #1297 (review)
I think we need to keep the PurePosixPath call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the
embedSdf.pyscript from #884 and adds some improvements to make it usable in support of the sdformat bazel build.This does not make sdf13 use the embedSdf script by default, instead still preferring the ruby version.