Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds title screen section to tutorial #83

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilkersonrdevon
Copy link

@wilkersonrdevon wilkersonrdevon commented Mar 7, 2024

Feature adds a title-screen directory with asm code that boots the game onto a "title screen" and after pressing start switches to the "game screen".

Closes #39

@avivace avivace requested review from avivace and ISSOtm March 8, 2024 08:09
@LaroldsJubilantJunkyard
Copy link
Contributor

Unbricked already has a main and a input here, so you shouldn't need an extra version. The title screen should show before gameplay. This code doesn't interact with the rest of the unbricked game. Also, there's no text added to the tutorial here. Those markdown files become the actual pages of the GB ASM Tutorial.

@wilkersonrdevon
Copy link
Author

wilkersonrdevon commented Mar 12, 2024

Unbricked already has a main and a input here, so you shouldn't need an extra version. The title screen should show before gameplay.

I might be confused on the project layout in this case. It seems like every section has its own subdirectory for each section of the tutorial that I tried to replicate for the title screen.

This code doesn't interact with the rest of the unbricked game.

Could you clarify? The way this sentence is structured has 2 meanings, either it should interact and isn't, or it shouldn't interact and is.

Also, there's no text added to the tutorial here. Those markdown files become the actual pages of the GB ASM Tutorial.

Issue #39 states "please propose an implementation, and send it in as a draft pull request. After a maintainer has greenlit your implementation, you can start writing the tutorial text, which describes the implementation."

@LaroldsJubilantJunkyard
Copy link
Contributor

Unbricked already has a main and a input here, so you shouldn't need an extra version. The title screen should show before gameplay.

I might be confused on the project layout in this case. It seems like every section has its own subdirectory for each section of the tutorial that I tried to replicate for the title screen.

This code doesn't interact with the rest of the unbricked game.

Could you clarify? The way this sentence is structured has 2 meanings, either it should interact and isn't, or it shouldn't interact and is.

Also, there's no text added to the tutorial here. Those markdown files become the actual pages of the GB ASM Tutorial.

Issue #39 states "please propose an implementation, and send it in as a draft pull request. After a maintainer has greenlit your implementation, you can start writing the tutorial text, which describes the implementation."

Okay, you are correct i misread the request and had to double-check on the format of the unbricked repo code.

After compiling, when i run the game, i see the splash screen.

image

Upon pressing the start button, i proceed to the next screen.

image

Copy link
Contributor

@LaroldsJubilantJunkyard LaroldsJubilantJunkyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise, Everything looks solid. Everything works fine when the ROM is compiled. The only thing i'm unsure about is during the 'TitleScreenLoop', if it's neccessary to wait for the vblank phase or not? Besides that, i think it looks ok.

@wilkersonrdevon
Copy link
Author

wilkersonrdevon commented Jun 8, 2024

Codewise, Everything looks solid. Everything works fine when the ROM is compiled. The only thing i'm unsure about is during the 'TitleScreenLoop', if it's neccessary to wait for the vblank phase or not? Besides that, i think it looks ok.

Since there's nothing else going on aside from a poll it's not strictly necessary. I could explain it in the description. Alternatively I could move the WaitVBlank2 to the top of the loop and create a third WaitVBlank in the original spot of the second one.

Btw, what position is this section in? I'm about to start writing the description and I want to stay within the timeline of events.

@avivace avivace requested review from Rangi42 and removed request for ISSOtm July 7, 2024 19:32
@avivace
Copy link
Member

avivace commented Jul 12, 2024

Hey @wilkersonrdevon , sorry for being late!

Codewise, Everything looks solid. Everything works fine when the ROM is compiled. The only thing i'm unsure about is during the 'TitleScreenLoop', if it's neccessary to wait for the vblank phase or not? Besides that, i think it looks ok.

Since there's nothing else going on aside from a poll it's not strictly necessary. I could explain it in the description. Alternatively I could move the WaitVBlank2 to the top of the loop and create a third WaitVBlank in the original spot of the second one.

I'd go for the first option and avoid adding a third WaitVBlank.

Btw, what position is this section in? I'm about to start writing the description and I want to stay within the timeline of events.

If I remember correctly, the idea was to add this Title Screen in Part 2 but I don't have a strong opinion regarding where to introduce this. Do you need concepts explained in other paragraphs of Part 2? I'd put it after "Bricks" for now..

Remember to mark the PR as ready to review whenever you feel like you're in a satisfying starting point.

@@ -0,0 +1,47 @@
; This is a simplified version of pads.z80 by PinoBatch for use in gb-asm-tutorial
; All labels are intentionally not exported to avoid confusing the reader with unfamiliar syntax.
; Once linking is introduced in part 3, a new, exported version of this file will be provided.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can open an issue regarding exporting labels in a later interaction?

@CodeWithMa
Copy link
Contributor

If this section is going to be after https://gbdev.io/gb-asm-tutorial/part2/functions.html it should probably use the Memcopy function to copy the tile data etc. right?

@avivace avivace requested a review from ISSOtm August 23, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a simple Title Screen to Part 2
4 participants