Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APU channel 3 docs should refer to channel 3 registers #517

Merged
merged 2 commits into from
Dec 14, 2023
Merged

APU channel 3 docs should refer to channel 3 registers #517

merged 2 commits into from
Dec 14, 2023

Conversation

iximeow
Copy link
Contributor

@iximeow iximeow commented Dec 13, 2023

just a simple copypaste error :)

@iximeow
Copy link
Contributor Author

iximeow commented Dec 13, 2023 •
edited
Loading

oh actually the trigger description reference the wrong register too. i'll edit just a bit more..

edit: fixed both references and adjusted PR title to match.

@iximeow iximeow changed the title low 8 bits of channel 3 period are in NR33, not NR13 APU channel 3 docs should refer to channel 3 registers Dec 13, 2023
ISSOtm
ISSOtm approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell reformatting the audio docs got really long and tiring? :')
Thanks for the fix. ^^

@ISSOtm ISSOtm merged commit 49d5c38 into gbdev:master Dec 14, 2023
2 checks passed
@iximeow iximeow deleted the patch-2 branch December 15, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iximeow @ISSOtm