Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #34

Open
1 of 3 tasks
avivace opened this issue Sep 16, 2024 · 4 comments
Open
1 of 3 tasks

Dark mode #34

avivace opened this issue Sep 16, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@avivace
Copy link
Member

avivace commented Sep 16, 2024

Current progress:

  • Support dark mode (System based theme #37)
  • Support manually setting a colour theme
  • Keep track of the manually-selected theme across sessions
@SelvinPL
Copy link
Contributor

#37 will do that
theme is based on syste/browser settings

you can check how it looks for both themes fx in chrome devtools via Rendering tab
image

image

@SelvinPL
Copy link
Contributor

dark

image

light

image

@SelvinPL
Copy link
Contributor

hmmm https://selvin.pl/rgbds-live/ has now selector for themes but i do not save them ... also not all themes looks goos as this is palette for ace and it's hard to choose from

@ISSOtm
Copy link
Member

ISSOtm commented Sep 18, 2024

I edited the OP to keep track of the sub-features. A PR for the second one can be opened, now that #37 has been merged?

As for the third one, I'd guess “check if a preference is set in localStorage; if not, set it to a default based on the system theme” should work?

@Rangi42 Rangi42 added the enhancement New feature or request label Sep 19, 2024
@Rangi42 Rangi42 changed the title dark mode Dark mode Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants