Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System based theme #37

Merged
merged 1 commit into from
Sep 18, 2024
Merged

System based theme #37

merged 1 commit into from
Sep 18, 2024

Conversation

SelvinPL
Copy link
Contributor

No description provided.

@SelvinPL SelvinPL mentioned this pull request Sep 16, 2024
Open
3 tasks
avivace
avivace approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks @SelvinPL ! Maybe we can add a manual toggle as well (a part from "guessing" it from the system?)

@Rangi42 Rangi42 mentioned this pull request Sep 17, 2024
Merged
@ISSOtm
Copy link
Member

ISSOtm commented Sep 18, 2024

(Rebased the branch on master.)

ISSOtm
ISSOtm approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but I'm not a Web expert.

@ISSOtm
Copy link
Member

ISSOtm commented Sep 18, 2024

Let's merge this for now, and keep tracking a manual toggle in #34.

@ISSOtm ISSOtm merged commit 325da0b into gbdev:master Sep 18, 2024
@ISSOtm ISSOtm mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

@avivace avivace avivace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SelvinPL @ISSOtm @avivace