Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorize and preserve newlines in log output #39

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Colorize and preserve newlines in log output #39

merged 2 commits into from
Sep 19, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Sep 17, 2024 •
edited
Loading

Fixes #26

image

image

@ISSOtm
Copy link
Member

ISSOtm commented Sep 18, 2024

Done! Looks like the changes will have to be ported to the new main.js instead.

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 18, 2024 •
edited
Loading

Done! @SelvinPL Please approve of this too. :)

@Rangi42 Rangi42 force-pushed the color-output branch 2 times, most recently from b62d6c9 to ab31040 Compare September 18, 2024 18:54
@Rangi42 Rangi42 requested a review from ISSOtm September 18, 2024 18:56
ISSOtm
ISSOtm previously requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Colour should make this easier to read in case of errors, too :)

css/style.css Outdated Show resolved Hide resolved
js/main.js Outdated Show resolved Hide resolved
@Rangi42 Rangi42 requested a review from ISSOtm September 19, 2024 01:32
ISSOtm
ISSOtm approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good to me.

js/main.js
} else {
output.innerHTML +=
"<u>" +
escapeHTML("[" + ("00" + value.toString(16)).slice(-2) + "]") +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install left-pad...~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unironically yes.

@ISSOtm ISSOtm requested a review from avivace September 19, 2024 10:35
avivace
avivace approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rangi42 !

@avivace avivace merged commit b00f846 into gbdev:master Sep 19, 2024
1 check passed
@SelvinPL
Copy link
Contributor

@Rangi42

Huston, we got a problem

image

vs

image

@Rangi42 Rangi42 deleted the color-output branch September 19, 2024 14:47
@SelvinPL
Copy link
Contributor

<!DOCTYPE html> is culprit ... i've also tried to add this but I saw that it fracks up website

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 19, 2024 •
edited
Loading

Huston, we got a problem

@SelvinPL Oops! Fixed in #48.

Edit: Jinx, I see you found the DOCTYPE issue as I was PRing it. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

@avivace avivace avivace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printing looks wrong and breaks the build
4 participants
@Rangi42 @ISSOtm @SelvinPL @avivace