Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use getopt(1) to provide -h, --help, and --dfsg options in test/fetch-test-deps.sh and test/run-tests.sh - -h or --help prints a usage message - --dfsg skips repositories with non-free licenses (pokecrystal and pokered) in favor of ucity to support packaging RGBDS for Debian - --dfsg can be combined with --get-hash or --get-paths change --dfsg option to --only-free I was told the `+dfsg.1` used in Debian's repacks of upstream repos and tarballs that contain non-free software is too obscure. ISSOtm and Rangi42 suggested `--only-free` which carries no Debian baggage. https://www.reddit.com/r/debian/comments/66094l/what_is_dfsg_in_package_version_numbers/ - change --dfsg option to --only-free - temporarily enable logging (set -x) to troubleshoot build failure on macOS don't depend on util-linux getopt util-linux getopt has long option parsing functionality not available in macOS getopt. Instead, parse the options in pure Bash, treating each option as a separate word. remove tracing from test The removal of getopt indeed fixed test scripts on macOS. This means we no longer need set -x to trace execution. Co-authored-by: Eldred Habert <[email protected]> use true/false for booleans in test scripts I haven't had a chance to read the `bash(1)` manual cover to cover (reading 6600 lines in `less(1)` is an attention challenge to me) but it appears `true` and `false` are preferred because `true(1)` and `false(1)` run faster than `test(1)`, to which `[` is a link. Co-authored-by: Eldred Habert <[email protected]> act on stylistic nitpicks by Rangi42 - remove explanation of `set -e` even from run-tests.sh, which had previously included one - visually distinguish explanations of sections of a script from explanations of individual functions within a section - change variable names that refer to script names to match the capitalized default filename of the script minus any extension - change variable names that do not refer to script names to lowercase Apply suggestions from code review Co-authored-by: Rangi <[email protected]> remane with_nonfree variable in tests to nonfree per @Rangi42's preference
- Loading branch information