Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dockerfile to build (and possibly run) RGBDS #1167

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add dockerfile to build (and possibly run) RGBDS #1167

merged 2 commits into from
Sep 14, 2023

Conversation

avivace
Copy link
Member

@avivace avivace commented Aug 28, 2023 •
edited
Loading

This basically follows https://github.com/gbdev/rgbds/blob/master/.github/workflows/create-release-artifacts.yaml#L96 and prepares a system to build (and run) RGBDS.

Why:

  • It allows generating Linux executables of RGBDS in a one-liner, not requiring root or the user to install the build dependencies. Choose a commit hash (or a tag), run the image, get your RGBDS release.
  • GH Actions pipelines are not really reproducible, as the runners are not OSS. This would provide a more future-proof way of testing what is necessary to get a build of RGBDS
  • There are a lot of RGBDS docker images around. It would be nice to provide official ones

@avivace avivace requested a review from ISSOtm August 28, 2023 12:14
@avivace avivace marked this pull request as draft August 28, 2023 12:14
ISSOtm
ISSOtm reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no opinion on Docker, I will defer to your judgement on anything related to it.

@avivace avivace mentioned this pull request Sep 13, 2023
Open
@avivace avivace marked this pull request as ready for review September 14, 2023 15:14
@avivace avivace merged commit 7a39e9e into master Sep 14, 2023
41 of 42 checks passed
@Rangi42
Copy link
Contributor

Rangi42 commented Sep 14, 2023

RELEASE.rst should have a step for updating the version here and anywhere else it's needed now, in addition to include/version.h.

@avivace
Copy link
Member Author

avivace commented Sep 15, 2023

RELEASE.rst should have a step for updating the version here and anywhere else it's needed now, in addition to include/version.h.

No additional step should be needed once #1170 is done

@Rangi42 Rangi42 deleted the builder-dockerfile branch November 8, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avivace @Rangi42 @ISSOtm