Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document STRUPR/STRLWR as ASCII-only #1187

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Document STRUPR/STRLWR as ASCII-only #1187

merged 2 commits into from
Oct 31, 2023

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Oct 29, 2023 •
edited
Loading

Fixes #639

This has two commits, one for some unrelated hex style, so don't squash it.

@Rangi42 Rangi42 requested a review from ISSOtm October 29, 2023 18:26
@Rangi42 Rangi42 added docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM labels Oct 29, 2023
@Rangi42 Rangi42 added this to the v0.6.2 milestone Oct 29, 2023
ISSOtm
ISSOtm previously requested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Was some auto-formatter set off? I'm not sure why there are any code changes. Normally I don't mind drive-by fixes, but this specific commit message would be really confusing in a blame...

man/rgbasm.5 Outdated Show resolved Hide resolved
@Rangi42 Rangi42 requested a review from ISSOtm October 30, 2023 00:31
@Rangi42
Copy link
Contributor Author

Rangi42 commented Oct 30, 2023

Was some auto-formatter set off? I'm not sure why there are any code changes. Normally I don't mind drive-by fixes, but this specific commit message would be really confusing in a blame...

I just didn't feel like making yet another PR just for some hex digits. Note that they are in a separate commit, so just don't squash this PR.

@Rangi42 Rangi42 merged commit ab42eb2 into gbdev:master Oct 31, 2023
24 checks passed
@Rangi42 Rangi42 deleted the ascii-case branch October 31, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@ISSOtm ISSOtm Awaiting requested review from ISSOtm

Assignees
No one assigned
Labels
docs This affects the documentation (web-specific issues go to rgbds-www) rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Document string case conversion as ASCII-only
3 participants
@Rangi42 @avivace @ISSOtm