Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requested revisions to recent PRs #1195

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Nov 1, 2023

@ISSOtm Collecting your feedback on already-merged PRs here.

@Rangi42 Rangi42 added this to the v0.7.0 milestone Nov 1, 2023
@Rangi42 Rangi42 requested a review from ISSOtm November 1, 2023 03:18
@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! docs This affects the documentation (web-specific issues go to rgbds-www) labels Nov 1, 2023
ISSOtm
ISSOtm previously requested changes Nov 2, 2023
man/rgbasm.5 Show resolved Hide resolved
man/rgbasm.1 Show resolved Hide resolved
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the other commits around that time, and there's nothing to add. Thank you for taking the time to make this!

man/rgbasm.1 Show resolved Hide resolved
@Rangi42 Rangi42 requested a review from ISSOtm November 7, 2023 22:05
@ISSOtm ISSOtm merged commit 5379e51 into gbdev:master Nov 7, 2023
24 checks passed
@Rangi42 Rangi42 deleted the revised branch November 7, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! docs This affects the documentation (web-specific issues go to rgbds-www)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants