Improve fixed-point documentation #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
previously requested changes
Aug 7, 2024
ISSOtm
force-pushed
the
fixpoint-doc
branch
2 times, most recently
from
37deea2
to
4df0a82
Compare
This was referenced Aug 7, 2024
Rangi42
added
enhancement
There was a space between the opening parens an `SIN`
Use fewer magic constants, and a FOR loop. Also use a max input bound that isn't 1.0, to avoid confusion with the `1.0` that's used to shift the output range.
They were not equivalent, and besides, it seems more likely that the shifts would confuse newbies while not bringing useful info to experts.
This should help, I think?
|
(Rebased on top of #1450.) |
ISSOtm
dismissed
Rangi42’s stale review
Consensus changes applied, and ongoing discussion spun off into separate issue
Rangi42
previously requested changes
Aug 8, 2024
Co-authored-by: Sylvie <[email protected]>
Rangi42
reviewed
Aug 8, 2024
Co-authored-by: Sylvie <[email protected]>
Rangi42
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may be best reviewed commit by commit.