Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGBFIX tests for MBC names #1477

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add RGBFIX tests for MBC names #1477

merged 1 commit into from
Aug 20, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Aug 20, 2024

Fixes #706
Checks a box in #1276

All the new mbc-*.flags tests use the all-zero default-input.bin as input.

@Rangi42 Rangi42 added tests This affects the test suite rgbfix This affects RGBFIX labels Aug 20, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Aug 20, 2024
@Rangi42 Rangi42 requested a review from ISSOtm August 20, 2024 03:26
@Rangi42 Rangi42 force-pushed the fix-tests branch 2 times, most recently from f68f913 to 177e321 Compare August 20, 2024 04:14
RGBFIX tests are now based on .flags files
The .bin and .err files are optional
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deserve so many credits for taking the time to go through these laborious tasks. Thank you so much!

@ISSOtm ISSOtm merged commit 7d98b9a into gbdev:master Aug 20, 2024
22 checks passed
@Rangi42 Rangi42 deleted the fix-tests branch August 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rgbfix This affects RGBFIX tests This affects the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for rgbfix's MBC name support
2 participants