Simplify some C++ abstractions #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only RGBGFX was using namespaces, and not in consistent ways. (For example,
packingandsortingwere namespace equivalents of the snake_case prefixes used in the other programs, butdetailwas for "private" templates in headers, andoptimized/unoptimizedwere kind of arbitrary.) So this just removes them entirely.This avoids potentially referring to values/functions in two ways (namespace-qualified, or unqualified in their "own" file), or worse, the same name in two namespaces (e.g.
outputTileData).This also removes or reduces usage of some other C++ abstractions (
using,friend) when they're not necessary.