Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setmode instead of fdopen #1520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use setmode instead of fdopen #1520

wants to merge 1 commit into from

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Sep 26, 2024

Based on #1502 (comment)

I'll see if this fixes the build in OpenBSD.

@Rangi42 Rangi42 added the refactoring This PR is intended to clean up code more than change functionality label Sep 26, 2024
@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 26, 2024

It did not:

image

@ISSOtm
Copy link
Member

ISSOtm commented Sep 26, 2024

And if you remove the “POSIX SOURCE” flag from the makefile?

@Rangi42
Copy link
Contributor Author

Rangi42 commented Sep 26, 2024

No, just removing -D_POSIX_C_SOURCE=200809L breaks the build in Cygwin (tested on Windows 7).

@ISSOtm
Copy link
Member

ISSOtm commented Sep 26, 2024

Yes, but what about the combination thereof?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This PR is intended to clean up code more than change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants