Make ENDL optional like ENDSECTION
#1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
enhancement
ISSOtm
reviewed
Oct 15, 2024
There was a problem hiding this comment.
The change itself makes sense, IMO, but I'm also wondering whether we may want to introduce a -Wunclosed-load warning? Probably in -Wextra, if anywhere. (I'm not concerned about -Wunclosed-section, because the difference is that forgetting to close a LOAD can end up over-reserving RAM without producing an error, whereas directives that work inside of a SECTION are not affected by the presence of one.)
Rangi42
force-pushed
the
endl-optional
branch
from
8b69325
to
2e9f090
Compare
|
Done! I've added |
ISSOtm
approved these changes
Oct 16, 2024
Rangi42
force-pushed
the
endl-optional
branch
from
84770cc
to
af5a9b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1534