Don't use pkg-config for libpng with CMake #1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may have only been added in the first place for 1-to-1 compatibility with the Makefile.
Rangi42
added
tests
|
Actually this is what's making CI fail, so if #1539 omits this change then its CTest support should be mergable. |
|
I have no idea what's going on with that, and I don't have a Mac to test with, so... |
|
Found this: Given that I've upvoted and commented on every post there I guess I know why I had that... |
|
if you want to pull the changes from that branch again, I can remove them from the CTest stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may have only been added in the first place for 1-to-1 compatibility with the Makefile.
Split off from #1539 (@JL2210 please confirm this is OK?)