Add more RGBGFX test coverage #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSOtm
previously approved these changes
Oct 26, 2024
Not quite! 32-bit Windows fails ): |
Rangi42
force-pushed
the
gfx-tests
branch
7 times, most recently
from
0db2f37
to
760c7fa
Compare
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
I was running into some kind of bug involving a combination of
-d 1and-m(does mirroring not work for 1bpp images? does it work inconsistently, like with-rbut not without?), but couldn't figure it out, so am leaving that out of this. For now, this increases RGBGFX test coverage as expected.Also fixes a bug where we were not handling the
-Xand-Yoptions.