Property bags #14
Merged
Property bags #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The propertyBag is an object with a further constraint that, if present, the `tags` property is a list of strings. This extra constraint is not enforced. "ord", a compare function, is not derived because Yojson.Safe.compare does not exist. The value of an order is also not clear to me. A test is added that does a roundtrip of a sarif output taken from a Semgrep test case.
|
I derived ord initially in order for the check of uniqueness of element to work, but now it seems unnecessary |
gborough
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes propertyBag an object that can contain arbitrary json. The special status of the
tagsproperty is not enforced. In order to do so I found it necessary to not deriveordasYojson.Safe.comparedoesn't exist and I was unable to wrestle ATD to use a different function for comparison. I also question the usefulness of such a compare as the order is somewhat arbitrary.Then I took the test cases for semgrep and added them. I had to do some very minor massaging to make the tests pass: the order of the top level properties in the sarif object had to be reordered, and then I filtered the resulting json through
ydump -cto make it compact.This addressed #10.