Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Zygote extension depend on ForwardDiff too #303

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Jun 5, 2024

DI extensions

  • Add ForwardDiff to the list of triggers for the Zygote extension, since it is needed by the HVP

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (042d75f) to head (ce5fd10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   96.42%   93.12%   -3.31%     
==========================================
  Files          71       71              
  Lines        3973     3971       -2     
==========================================
- Hits         3831     3698     -133     
- Misses        142      273     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 7d99da1 into main Jun 5, 2024
32 checks passed
@gdalle gdalle deleted the gd/zygote_extension branch June 5, 2024 06:13
@adrhill
Copy link
Collaborator

adrhill commented Jun 5, 2024

Does this mean Zygote can only be used if ForwardDiff is loaded as well?

@gdalle
Copy link
Owner Author

gdalle commented Jun 5, 2024

Yes. In practice it doesn't change anything because ForwardDiff is a dependency of Zygote anyway, and dropping it would be a breaking Zygote change so we'd see it coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants