Chore : OCI Migration #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekgns33
approved these changes
Oct 13, 2024
| @@ -107,7 +107,7 @@ public ClientRegistrationRepository clientRegistrationRepository() { | |||
| private CorsConfigurationSource corsConfigurationSource() { | |||
| CorsConfiguration configuration = new CorsConfiguration(); | |||
|
|
|||
| configuration.setAllowedOrigins(Arrays.asList("http://localhost:5173", "https://stage.gdsc-konkuk.dev", "https://gdsc-konkuk.dev")); | |||
| configuration.setAllowedOrigins(Arrays.asList("http://localhost:5173", "https://stage.gdsc-konkuk.dev", "https://gdsc-konkuk.dev", "https://admin.gdsc-konkuk.dev", "https://member.gdsc-konkuk.dev", "https://landing.gdsc-konkuk.dev")); | |||
There was a problem hiding this comment.
상수사용이 어떨지 제안합니다. 테스트할때 바꾸는게 귀찮더라구여
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCI Migration
Background
AWS EC2
t2.small의 서버 비용이 감당하기 어려워 OCI의 Always Free Resources를 활용하기로 하는 의사 결정이 이뤄졌습니다. 이 과정에서arm64기반의 instance로 migration 하며Dockerfile과build.sh를 수정해야 했습니다. (docker buildx명령어에 주목해 주세요)하는 김에 하자 (PR 사이즈 죄송합니다죄송합니다)
build.gradle다듬기tasks.named("task") {}와task {}가 혼용되고 있었습니다.postmantask 실행 시 baseURL 설정excludeSecrets옵션을 통해application.yaml을 build에서 제외application-prod.yaml을 분리하고 버전 관리에 추가했습니다.admin.gdsc-konkuk.dev,member.gdsc-konkuk.dev,landing.gdsc-konkuk.dev