Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animation added #62

Merged
merged 2 commits into from
Feb 3, 2022
Merged

animation added #62

merged 2 commits into from
Feb 3, 2022

Conversation

mnnkhndlwl
Copy link
Contributor

@mnnkhndlwl mnnkhndlwl commented Feb 2, 2022

2022-02-02.19-22-03.mp4

Description

I have added a button animation and I have added video of the final result please see that

(Write your answer here.)

Checklist

  • [x ] I am making a proper pull request, not spam.
  • [x ] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests

Related to issue #17

Add relevant screenshot or video (if any)

RESULT

(Add here)

Copy link
Member

@ZiaCodes ZiaCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnnkhndlwl #62
Hey , Can you improve the aimation like it doesn't fit to this application.
It will be better if you try something else

@mnnkhndlwl
Copy link
Contributor Author

2022-02-02.20-21-32.mp4
2022-02-02.20-35-00.mp4

This time i tried two different animation check them if you like

@ZiaCodes
Copy link
Member

ZiaCodes commented Feb 2, 2022

@mnnkhndlwl okay great

@mnnkhndlwl
Copy link
Contributor Author

which one should i commit

@mnnkhndlwl
Copy link
Contributor Author

first one or second one

@ZiaCodes
Copy link
Member

ZiaCodes commented Feb 2, 2022

@mnnkhndlwl do the last one

@mnnkhndlwl
Copy link
Contributor Author

mnnkhndlwl commented Feb 2, 2022

@ZiaCodes I have commited the changes

@mnnkhndlwl
Copy link
Contributor Author

@ZiaCodes sir please merge it

@ZiaCodes
Copy link
Member

ZiaCodes commented Feb 3, 2022

@ZiaCodes sir please merge it

working on it

Copy link
Member

@ZiaCodes ZiaCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnnkhndlwl #62

okay Done

@ZiaCodes ZiaCodes merged commit 979f168 into gdscjgec:main Feb 3, 2022
@mnnkhndlwl mnnkhndlwl deleted the button_animation branch February 3, 2022 05:53
@mnnkhndlwl
Copy link
Contributor Author

@ZiaCodes sir one more request i was unable to add labels into it so can you please add label jwoc or easy in it

@ZiaCodes ZiaCodes added easy Points will be: 1(1st Phase), 2(2nd Phase). 1 day will be allotted. Easy: 1 day Complete within 1 day JWOC This issue/pull request will be considered for JWOC 2k22. labels Feb 3, 2022
@ZiaCodes
Copy link
Member

ZiaCodes commented Feb 3, 2022

@ZiaCodes sir one more request i was unable to add labels into it so can you please add label jwoc or easy in it

Okay done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Points will be: 1(1st Phase), 2(2nd Phase). 1 day will be allotted. Easy: 1 day Complete within 1 day JWOC This issue/pull request will be considered for JWOC 2k22.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants