-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sky130nm
inverter schematic-driven-layout design & hdl21
integration
#356
base: main
Are you sure you want to change the base?
Conversation
sky130nm
inverter schematic-driven-layout design using gplugins
b149ba7
to
62282ab
Compare
sky130nm
inverter schematic-driven-layout design using gpluginssky130nm
inverter schematic-driven-layout design & hdl21
integration
75ce750
to
208d7a1
Compare
ad73efa
to
8a1fabf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
fc04df6
to
0b450e4
Compare
28d748a
to
52757f7
Compare
Hi Joaquin, hope you're well ☀️ , I think the base functionality is ready to build upon for more complex examples. This includes a demo from going from a sky130 SPICE-to-layout schematic editor functionality, which can be built upon and modified. What do you think? More complex sky130 analog layout examples can now be done imo, and maybe you know how to best polish/present the schematic with the port implementations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.
for more information, see https://pre-commit.ci
…to demo_spice_layout
Hi @joamatab! So I've tried to fix the actions that were not passing (adding the hdl21 module dependency into the action is a bit strange, I've followed the other cases and yet it doesn't import hdl21 correctly, what do you think?). For the last test I've also implemented the resistor ladder of a R2R-based DAC from hdl21, see the screenshot: Hopefully this may be useful/helpful to you during your FSIC presentation which I look forward to! I believe there is a lot of power in this functionality now, and a good direction to grow - since there might be easier ways to translate from vlsir-xschem than directly to gdsfactory(but now they can be imported like this directly since it's the same proto as hdl21). |
Just making a draft branch to work from
gdsfactory/skywater130#86
#306
This PR:
As this is currently very fluid, I expect this PR to supersede gdsfactory/skywater130#94