Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest gdsfactory #334

Merged
merged 1 commit into from
Nov 20, 2023
Merged

update to latest gdsfactory #334

merged 1 commit into from
Nov 20, 2023

Conversation

joamatab
Copy link
Contributor

should work even with older versions of gdstk

fixes #333

@lukasc-ubc

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d66f4f) 71.63% compared to head (631bbae) 71.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files          18       18           
  Lines         744      744           
=======================================
  Hits          533      533           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit eb71b9d into main Nov 20, 2023
5 of 6 checks passed
@joamatab joamatab deleted the update_latest_gdsfactory7818 branch November 20, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install ubcpdk, fails
1 participant