Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" to gcc-9 and higher builds in GitHub Actions CI #361

Conversation

esabol
Copy link
Member

@esabol esabol commented Nov 21, 2022

This pull request partially addresses issue #354 by restoring CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" to the gcc-9 and higher builds in GitHub Actions CI. This was previously in the Travis CI, but I forgot to include it in the transition to GitHub Action CI. The gcc documentation says that it "enables extra error checking in the form of precondition assertions, such as bounds checking in strings and null pointer checks when dereferencing smart pointers." This was useful in finding multiple errors in the gearmand source code in the past.

@esabol esabol force-pushed the add-GLIBCXX_ASSERTIONS-to-CI-for-gcc-9-and-higher branch from 77594ab to 4af38f8 Compare November 21, 2022 04:36
@esabol esabol force-pushed the add-GLIBCXX_ASSERTIONS-to-CI-for-gcc-9-and-higher branch from 4af38f8 to 5a00245 Compare November 21, 2022 04:42
@SpamapS SpamapS merged commit 6b75611 into gearman:master Nov 25, 2022
@esabol esabol deleted the add-GLIBCXX_ASSERTIONS-to-CI-for-gcc-9-and-higher branch February 17, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants