Explicitly retype timespec fields to int64_t to fix compatibility with 32bit arches. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h 32bit arches. Timespec fields' time_t type is not guaranteed to be any particular integer. Tests with binary timestamp conversion are failing on 32bit arches (e.g. intel x86) until they are retyped into int64_t, which fixes the issue with encoding the Time instances. Decoder doesn't need adjusting. It returns the correct time from the encoded binary representation. Resolves: ged#545
|
Note that I have only tested this in Fedora's i386 environment via mock. But the tests on Fedora with the patch that is included within this PR seems to pass for Fedora supported arches OK: https://koji.fedoraproject.org/koji/taskinfo?taskID=107830936 You can inspect each build (running rspec tests included) by clicking on individual "descendants" buildArch fields and then clicking on the "build.log" that's at the bottom with the "Output" field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timespec fields' time_t type is not guaranteed to be any particular integer. Tests with binary timestamp conversion are failing on 32bit arches (e.g. intel x86) until they are retyped into int64_t, which fixes the issue with encoding the Time instances.
Decoder doesn't need adjusting. It returns the correct time from the encoded binary representation.
Resolves: #545