Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: add more test #17

Merged
merged 2 commits into from
Dec 9, 2024
Merged

improve: add more test #17

merged 2 commits into from
Dec 9, 2024

Conversation

Blankll
Copy link
Member

@Blankll Blankll commented Dec 9, 2024

improve: add more test

  • improve test coverage for rosClient
  • improve test coverage for iacHelper
  • improve test coverage for getVersion

Refs:

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (d7453e0) to head (cffdd38).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   81.04%   92.87%   +11.83%     
===========================================
  Files          37       38        +1     
  Lines         364      365        +1     
  Branches       49       49               
===========================================
+ Hits          295      339       +44     
+ Misses         60       11       -49     
- Partials        9       15        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blankll Blankll marked this pull request as ready for review December 9, 2024 17:00
@Blankll Blankll merged commit 287ddb8 into master Dec 9, 2024
4 checks passed
@Blankll Blankll deleted the improve/test-improvement branch December 9, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant