Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload code zip file to bucket issue #22

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

Blankll
Copy link
Member

@Blankll Blankll commented Dec 15, 2024

fix: upload code zip file to bucket issue

  • use oss_deployment to upload code to the oss bucket for code size > 15MB

Refs: #5

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 51.16279% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (bba9248) to head (94a4f5d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/common/rosClient.ts 22.22% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   88.72%   84.92%   -3.81%     
==========================================
  Files          40       40              
  Lines         417      451      +34     
  Branches       55       57       +2     
==========================================
+ Hits          370      383      +13     
- Misses         31       52      +21     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blankll Blankll marked this pull request as ready for review December 19, 2024 16:31
@Blankll Blankll merged commit cdb4517 into master Dec 19, 2024
2 checks passed
@Blankll Blankll deleted the fix/ros-bucket-artifacts branch December 19, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant