Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: si-bootstrap stack created for holding the common resources #24

Merged
merged 10 commits into from
Dec 21, 2024

Conversation

Blankll
Copy link
Member

@Blankll Blankll commented Dec 19, 2024

feat|fix|refactor: summary title of the PR

  • create new stack: serverlessInsight-bootstrap-${iamInfo?.accountId}-${context.region} to holding common resources like artifacts bucket
  • fix the deploy dependencies issue

Refs: #5

@Blankll Blankll changed the title Fix/ros bucket artifacts feat: si-bootstrap stack created for holding the common resources Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (cdb4517) to head (3cecef4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/common/imsClient.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files          40       42    +2     
  Lines         451      471   +20     
  Branches       57       59    +2     
=======================================
+ Hits          383      400   +17     
- Misses         52       55    +3     
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blankll Blankll marked this pull request as ready for review December 21, 2024 08:44
@Blankll Blankll merged commit 110366f into master Dec 21, 2024
4 checks passed
@Blankll Blankll deleted the fix/ros-bucket-artifacts branch December 21, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant