fix(keyboard): improve keyboard hook with callback #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for geist-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hey @unix can you give it a look ? 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change information
React.useCallbackto memoize the event handler function for better performance and to avoid unnecessary re-renders.React.useCallbackdependencies array to ensure that the function is correctly updated when any of its dependencies change.React.useEffectwith a full dependency array to ensure that the event listener is correctly added and removed when the component mounts and unmounts, respectively (which wasn't the case before).isCaptureandelementEventTypearguments of theelementBindingHandlerfunction.