-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resourecs: Update make.def to make is.D.x for x86 image #58
base: stable
Are you sure you want to change the base?
Conversation
- To build is.D.x each isa would require different compiler flags. Updating the location of make.def as there would be one for each ISA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a good understanding of the make.def files, but I ran is.a, is.c, and is.d using the built disk image. is.a and is.c run while is.d seg faults, but this is probably expected behavior since it uses more memory than the X86Board can accommodate.
I created the X86 disk image from this repo from scratch. Tested it on my own infrastructure that actually has a memory size > 3 GiB allowing to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the compiler flags in make.def to make is.D.x for the x86 image