Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

feat(*): add system/testFormats option to config #733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tx44
Copy link

@tx44 tx44 commented Feb 12, 2017

For using not only .js extensions in tests.

gemini-testing/gemini-core#5
researchgate/gemini-react#28

@levonet levonet added the review label Feb 12, 2017
Copy link
Contributor

@j0tunn j0tunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for long delay.
Can you also fix tests?

.build({
root: config.system.projectRoot,
formats: config.system.testFormats
}, {ignore: config.system.exclude})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets pass all this options via single object:

.build({
    root: config.system.projectRoot,
    formats: config.system.fileExtensions,
    globOpts: {
        ignore: config.system.exclude
    }
})

* `testFormats` - array of filename extensions for tests to proceed. `.js` is available by default, override this if you want:

```yaml
testFormats:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rename testFormats to fileExtensions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants