serialize and deserialize recycled entity ids to/from json #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes a bug in which loading a world that previously had recycled entities, new entities created after loading could be created that reuse existing entity ids, causing havoc.
|
Could you probably add support for binary aswell? ^^ |
Of course! I didn't want to do it until this was reviewed though in case there was a better solution I hadn't considered for recycled entity ids. |
|
Can this be merged? I guess so right? |
Yeah it should be fine, the checks are failing because the version of Arch it's pointed at is wrong, but otherwise it works. |
genaray
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which loading a world that previously had recycled entities, new entities created after loading could be created that reuse existing entity ids, causing havoc.
This should be done for binary as well.