Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds category group #213

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rrahn
Copy link
Contributor

@rrahn rrahn commented Aug 23, 2018

Allows external configuration systems to boostrap plugins from different
providers into a core plugin for distribution.

Allows external configuration systems to boostrap plugins from different
providers into a core plugin for distribution.
@rrahn
Copy link
Contributor Author

rrahn commented Aug 23, 2018

@jpfeuffer @AlexanderFillbrunn can you point me to the tests, so I can add one for the feature. And to give you a scenario. I want to be able to ship in one plugin version sources from multiple vendors. To show that some of the tools are SeqAn and others from external vendors I can add this on a configuration level and highlight it visually.

@AlexanderFillbrunn
Copy link
Collaborator

Makes sense. But maybe the default should be for getCategoryGroup to return null, so people do not have to implement it explicitly and only overwrite it if necessary. I am afraid we don't have any tests for this yet, unless @jpfeuffer wrote some.

@rrahn
Copy link
Contributor Author

rrahn commented Aug 27, 2018

It makes sense to make it not abstract. I'll change this.

@jpfeuffer
Copy link
Member

There are some rudimentary tests in the com.gkn. ... . test package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants