Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NLog Dependency #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fr4nky80
Copy link

@fr4nky80 fr4nky80 commented Nov 26, 2024

Remove NLog Dependency

Description

This PR removes the dependency on NLog, enhancing the flexibility and portability of the project. By eliminating this dependency, the library can integrate more easily into projects that do not use or prefer alternative logging frameworks.

Changes

  • Replaced NLog-specific logging calls with a generic logging abstraction to maintain logging capabilities without coupling to a specific implementation.
  • Introduced dependency injection to allow users to plug in their preferred logging provider (e.g., Microsoft.Extensions.Logging).
  • Updated documentation to reflect the changes and provide guidance for configuring custom logging.

Benefits

  • Decouples the library from NLog, reducing unnecessary dependencies.
  • Allows developers to use the logging provider of their choice.
  • Improves maintainability and aligns the library with modern .NET practices.

Breaking Changes

  • Existing projects using NLog directly through this library will need to configure logging explicitly using the new abstraction.

Related Issues

(If applicable, link any issues or feature requests here.)


Please review the changes and let me know if further adjustments are needed.

Thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants