Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

26 add support for illumina #39

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

26 add support for illumina #39

wants to merge 5 commits into from
+308 −151

Conversation

AnderssonOlivia
Copy link

Fixes #26

@AnderssonOlivia AnderssonOlivia requested a review from fwa93 January 10, 2025 12:14
@AnderssonOlivia AnderssonOlivia requested a review from a team as a code owner January 10, 2025 12:14
@AnderssonOlivia AnderssonOlivia linked an issue Jan 10, 2025 that may be closed by this pull request
Add support for illumina #26
Open
fwa93
fwa93 reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@fwa93 fwa93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not go with subworkflows?
Maybe one for long read and one for short read and later one for pacbio?
What do you thoughts about this?

fwa93
fwa93 requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@fwa93 fwa93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need quay.io in the module-file for docker images
''quay.io/biocontainers/cutadapt:4.6--py39hf95cd2a_1' }"

@AnderssonOlivia

edit: tagged AnderssonOlivia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwa93 fwa93 fwa93 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for illumina
2 participants
@AnderssonOlivia @fwa93