Clean up pipeline tests #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fellen31
force-pushed
the
update-pipeline-tests
branch
8 times, most recently
from
c9189df
to
10eb3ba
Compare
fellen31
force-pushed
the
update-pipeline-tests
branch
from
33b784d
to
dd7300a
Compare
fellen31
force-pushed
the
update-pipeline-tests
branch
4 times, most recently
from
1e0ec67
to
0acfc2a
Compare
fellen31
force-pushed
the
update-pipeline-tests
branch
from
0acfc2a
to
540ad23
Compare
Schmytzi
reviewed
Oct 25, 2024
nf-test.config
Outdated
| // location of an optional nextflow.config file specific for executing tests | ||
| configFile "conf/test.config" | ||
| // run all test with defined profile(s) from the main nextflow.config | ||
| profile "test,docker" |
There was a problem hiding this comment.
I don't understand why you specify test,docker as the default profile here but only test in the tests themselves. I think, they should either be consistent or you set the profile only here. (Also, I don't know which one takes precedence)
There was a problem hiding this comment.
You are right, I'll remove the profile part from the tests, and updated this to only profile "test".
| } | ||
| } | ||
|
|
||
| then { |
There was a problem hiding this comment.
Suggested change
| then { | |
| then { |
Messed up indentation. I think it's like that in the other tests, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #375
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).