-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hifiasm to 0.20 #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, could you also add --dual-scaf --telo-m CCCTAA
as args in the config (and add a line about this in the CHANGELOG)?
nallo/conf/modules/genome_assembly.config
Line 28 in 2caa215
ext.args = { "${params.extra_hifiasm_options}" } |
You can use the same formatting as here:
nallo/conf/modules/methylation.config
Lines 27 to 33 in 2caa215
withName: '.*:METHYLATION:MODKIT_PILEUP_UNPHASED' { | |
ext.args = { [ | |
"${params.extra_modkit_options}", | |
'--combine-mods', | |
'--cpg', | |
'--combine-strands', | |
].join(' ') } |
Two of the pipeline tests need updating (nf-test test --tag PIPELINE --profile docker --update-snapshot
).
.multiMap { meta, reads, paternal_yak, maternal_yak -> | ||
reads : [meta, reads ] | ||
yak : [meta, paternal_yak, maternal_yak] | ||
} | ||
.set { ch_hifiasm_in } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Sorry you had to go through this part of the pipeline 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Felix Lenner <[email protected]>
Co-authored-by: Felix Lenner <[email protected]>
Closes #295.
Updated HiFiAsm to 0.20 and changed arguments to account for the new input spec.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).