Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hifiasm to 0.20 #440

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Conversation

Schmytzi
Copy link
Collaborator

@Schmytzi Schmytzi commented Oct 24, 2024

Closes #295.
Updated HiFiAsm to 0.20 and changed arguments to account for the new input spec.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@Schmytzi Schmytzi marked this pull request as ready for review October 24, 2024 13:17
@Schmytzi Schmytzi requested a review from a team as a code owner October 24, 2024 13:17
Copy link
Collaborator

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you also add --dual-scaf --telo-m CCCTAA as args in the config (and add a line about this in the CHANGELOG)?

ext.args = { "${params.extra_hifiasm_options}" }

You can use the same formatting as here:

withName: '.*:METHYLATION:MODKIT_PILEUP_UNPHASED' {
ext.args = { [
"${params.extra_modkit_options}",
'--combine-mods',
'--cpg',
'--combine-strands',
].join(' ') }

Two of the pipeline tests need updating (nf-test test --tag PIPELINE --profile docker --update-snapshot).

modules/nf-core/hifiasm/hifiasm.diff Show resolved Hide resolved
Comment on lines +100 to +104
.multiMap { meta, reads, paternal_yak, maternal_yak ->
reads : [meta, reads ]
yak : [meta, paternal_yak, maternal_yak]
}
.set { ch_hifiasm_in }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Sorry you had to go through this part of the pipeline 😄

Copy link
Collaborator

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Schmytzi and others added 2 commits October 24, 2024 21:13
Co-authored-by: Felix Lenner <[email protected]>
Co-authored-by: Felix Lenner <[email protected]>
@Schmytzi Schmytzi merged commit 6a93afc into genomic-medicine-sweden:dev Oct 24, 2024
18 checks passed
@Schmytzi Schmytzi deleted the hifiasm-0.20 branch October 24, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update hifiasm to 0.19.9-r616 to make use of --telo-m CCCTAA and --ctg-n
2 participants