-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add found_in tag and nf-test to call repeat expansions #445
Add found_in tag and nf-test to call repeat expansions #445
Conversation
9d4989b
to
4359d94
Compare
sample_bam = SAMTOOLS_SORT_TRGT.out.bam // channel: [ val(meta), path(bam) ] | ||
sample_bai = SAMTOOLS_INDEX_TRGT.out.bai // channel: [ val(meta), path(bai) ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its a sample_bam with its corresponding sample_bai, wouldn't it be better to output them together as one channel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what I wrote in the previous comment holds true somewhat here as well, some tools that require a bam file do not require a bai (although to be fair most do).
I think the tests get easier to read and write if we can standardise and know that there's only a meta and a file in the output channels from each workflow.
E.g.:
path(workflow.out.project_vcf[0][1])).vcf.variantsMD5,
{ assert process.out.tbi[0][1].endsWith(".tbi") }
vs.
path(workflow.out.project_vcf_tbi[0][0][0])).vcf.variantsMD5,
{ assert process.out.project_vcf_tbi[0][0][1].endsWith(".tbi") }
Especially if there's a mix of output channels with different number of elements (which there will be, because not all file types have an index).
Most nf-core modules output one file per output, so to me it makes sense to try to keep subworkflows the same as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that in this case it's a bit different because you could end up putting together the wrong bam with the wrong bai but it's a mater of taste. So I will approve the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sample_bam = SAMTOOLS_SORT_TRGT.out.bam // channel: [ val(meta), path(bam) ] | ||
sample_bai = SAMTOOLS_INDEX_TRGT.out.bai // channel: [ val(meta), path(bai) ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that in this case it's a bit different because you could end up putting together the wrong bam with the wrong bai but it's a mater of taste. So I will approve the PR :)
d835081
to
2df51f1
Compare
2df51f1
to
b93f653
Compare
Closes #391
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).