Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set baseHref to "/demo" (Fixes #5) #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rafacm
Copy link

@rafacm rafacm commented Mar 29, 2018

No description provided.

@leonadler leonadler self-requested a review March 30, 2018 08:45
@leonadler leonadler self-assigned this Mar 30, 2018
@leonadler
Copy link

leonadler commented Mar 30, 2018

Thank you for your pull request!

However, the demo is meant to be served from /demo (updated in 23016f0).
I'll check if we can trigger angular-cli to launch the browser at that url.

@leonadler leonadler mentioned this pull request Mar 30, 2018
@rafacm rafacm changed the title Set baseHref to "/" (Fixes #5) Set baseHref to "demo" (Fixes #5) Mar 30, 2018
@rafacm rafacm changed the title Set baseHref to "demo" (Fixes #5) Set baseHref to "/demo" (Fixes #5) Mar 30, 2018
@rafacm
Copy link
Author

rafacm commented Mar 30, 2018

However, the demo is meant to be served from /demo (updated in 23016f0).

OK!

As far as I can see with the following in .angular-cli.json:

   "baseHref": "/demo/"

access to the app at

  1. http://localhost:4200/demo/ (note the trailing "/" ) does NOT work with errors shown in Error: GET http://localhost:4200/demo/inline.bundle.js net::ERR_ABORTED #5 💥
  2. http://localhost:4200/demo (without trailing "/") does NOT work with errors shown in Error: GET http://localhost:4200/demo/inline.bundle.js net::ERR_ABORTED #5 💥

With

   "baseHref": "/demo"

access to the app at

  1. http://localhost:4200/demo/ (note the trailing "/" ) does work 👍
  2. http://localhost:4200/demo (without trailing "/") does work 👍

I have just pushed a commit to this PR setting "baseHref" to "/demo".

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@leonadler leonadler removed their assignment Aug 5, 2019
@leonadler
Copy link

@Jotschi can you remove me from the reviewer list, please? thanks! 🎆

@Jotschi
Copy link
Contributor

Jotschi commented Mar 26, 2021

@leonadler That must be done by @plyhun or @bernhardriegler - I'm no longer working for Gentics and don't have admin access.

@leonadler
Copy link

@plyhun @bernhardriegler can you remove me from the reviewer list, please? thanks! 🎆

@Jotschi oh, damn! - if you want to reveal that, where is your journey taking you?
All the best on your next steps in any way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants