chore: paginate and knip fix

gentlementlegen · Aug 6, 2024 · 30ca585 · 30ca585
1 parent f7e5244
commit 30ca585
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/handlers/shared/check-assignments.ts b/src/handlers/shared/check-assignments.ts
@@ -1,4 +1,4 @@
-import { Context, IssueEvent } from "../../types";
+import { Context } from "../../types";
 import { getAppId } from "../../utils/shared";
 
 export async function hasUserBeenUnassigned(context: Context): Promise<boolean> {
@@ -20,11 +20,11 @@ export async function hasUserBeenUnassigned(context: Context): Promise<boolean>
 async function getAssignmentEvents(context: Context) {
   const { repository, issue } = context.payload;
   try {
-    const { data } = (await context.octokit.issues.listEventsForTimeline({
+    const data = await context.octokit.paginate(context.octokit.issues.listEventsForTimeline, {
       owner: repository.owner.login,
       repo: repository.name,
       issue_number: issue.number,
-    })) as IssueEvent;
+    });
 
     const events = data
       .filter((event) => event.event === "assigned" || event.event === "unassigned")
@@ -53,7 +53,6 @@ async function getAssignmentEvents(context: Context) {
         return new Date(a.createdAt || "").getTime() - new Date(b.createdAt || "").getTime();
       });
   } catch (error) {
-    const log = context.logger.error("Error while getting assignment events", { error: error as Error });
-    throw new Error(log?.logMessage.diff as string);
+    throw context.logger.error("Error while getting assignment events", { error: error as Error });
   }
 }
diff --git a/src/types/payload.ts b/src/types/payload.ts
@@ -1,13 +1,11 @@
 import { RestEndpointMethodTypes } from "@octokit/rest";
 
 export type Issue = RestEndpointMethodTypes["issues"]["get"]["response"]["data"];
-export type PullRequest = RestEndpointMethodTypes["pulls"]["list"]["response"]["data"][0];
 export type Label = RestEndpointMethodTypes["issues"]["listLabelsOnIssue"]["response"]["data"][0];
 export type Review = RestEndpointMethodTypes["pulls"]["listReviews"]["response"]["data"][0];
 export type TimelineEventResponse = RestEndpointMethodTypes["issues"]["listEventsForTimeline"]["response"];
 export type TimelineEvents = RestEndpointMethodTypes["issues"]["listEventsForTimeline"]["response"]["data"][0];
 export type Assignee = Issue["assignee"];
-export type IssueEvent = RestEndpointMethodTypes["issues"]["listEventsForTimeline"]["response"];
 export type GitHubIssueSearch = RestEndpointMethodTypes["search"]["issuesAndPullRequests"]["response"]["data"];
 export type Sender = { login: string; id: number };