Add control socket and implement pfresolvectl #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a control process and control socket to pfresolved, allowing it to be controlled from other programs. Also adds a new program called 'pfresolvectl' that utilizes this socket. It can be used to change the log level of pfresolved, reload the current configuration, or trigger pfresolved to write the hints file if configured. The implementation is based on 'control.c' from iked(8) and on ikectl(8).
bluhm
approved these changes
Mar 1, 2024
| @@ -1,6 +1,6 @@ | |||
| .\" $OpenBSD$ | |||
| .\" | |||
| .\" Copyright (c) 2023 genua GmbH <[email protected]> | |||
| .\" Copyright (c) 2024 genua GmbH <[email protected]> | |||
There was a problem hiding this comment.
The copyright for the old year remains. Write 2023,2024.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2023 genua GmbH | |||
| * Copyright (c) 2024 genua GmbH | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2023 genua GmbH | |||
| * Copyright (c) 2024 genua GmbH | |||
| } | ||
|
|
||
| while (!done) { | ||
| if ((n = imsg_read(ibuf)) == -1 && errno != EAGAIN) |
There was a problem hiding this comment.
This block does nothing. If you don't need it, remove it. It can be copied from iked anytime. If you fill the stub in your next change, this is also fine.
| @@ -74,7 +74,7 @@ forwarder_run(struct privsep *ps, struct privsep_proc *p, void *arg) | |||
| struct pfresolved *env = ps->ps_env; | |||
| int fd; | |||
|
|
|||
| if (pledge("stdio dns inet rpath", NULL) == -1) | |||
| if (pledge("stdio dns inet rpath recvfd", NULL) == -1) | |||
There was a problem hiding this comment.
I cannot see where this pledge is needed. I guess there is a follow up change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a control process and control socket to pfresolved, allowing it to be controlled from other programs. Also adds a new program called 'pfresolvectl' that utilizes this socket. It can be used to change the log level of pfresolved, reload the current configuration, or trigger pfresolved to write the hints file if configured.
The implementation is based on 'control.c' from iked(8) and on ikectl(8).