Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement fix for nested FilterComparers + other fixes #37

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

geo-martino
Copy link
Owner

@geo-martino geo-martino commented Mar 12, 2024

Changed

  • :py:class:.ItemSorter now accepts shuffle_weight between -1 and 1 instead of 0 and 1.
    This parameter's logic has not yet been implemented so no changes to functionality have been made yet.
  • Move :py:meth:.get_filepaths from :py:class:.LocalTrack to super class :py:class:.File

Fixed

  • :py:meth:.PrettyPrinter.json and :py:meth:.PrettyPrinter._to_str converts attribute keys to string
    to ensure safe json/str/repr output
  • :py:class:.FilterMatcher and :py:class:.FilterComparers now correctly import conditions from XML playlist files.
    Previously, these filters could not import nested match conditions from files.
    Changes to logic also made to :py:meth:.Comparer.from_xml to accommodate.
  • :py:class:.XMLLibraryParser now handles empty arrays correctly. Previously would crash.
  • Fixed :py:class:.Comparer dynamic process method alternate names for in_the_last and not_in_the_last

@geo-martino geo-martino linked an issue Mar 12, 2024 that may be closed by this pull request
1 task
@geo-martino geo-martino enabled auto-merge (squash) March 12, 2024 20:59
@geo-martino geo-martino merged commit 547fcee into master Mar 12, 2024
7 checks passed
@geo-martino geo-martino deleted the issue-32 branch March 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XAutoPF file reader does not handle match conditions correctly
1 participant