Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand FilterMatcher functionality with GroupBy settings #52

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

geo-martino
Copy link
Owner

@geo-martino geo-martino commented Mar 31, 2024

Begins to resolve #18 by clearing up some overlapping logical errors in ItemSorter and FilterMatcher

Added

  • Extend :py:class:.FilterMatcher with group_by tag functionality

Changed

  • :py:class:.ItemSorter now shuffles randomly on unsupported types
    • prioritises fields settings over shuffle settings

Removed

  • Redundant ShuffleBy enum and related arguments from :py:class:.ItemSorter

Documentation

  • Added info on lint checking for the contributing page

@geo-martino geo-martino linked an issue Mar 31, 2024 that may be closed by this pull request
1 task
@geo-martino geo-martino enabled auto-merge (squash) March 31, 2024 14:50
@geo-martino geo-martino disabled auto-merge March 31, 2024 14:54
@geo-martino geo-martino enabled auto-merge (squash) March 31, 2024 14:54
@geo-martino geo-martino merged commit 7d4d8a0 into master Mar 31, 2024
7 checks passed
@geo-martino geo-martino deleted the expand-sorter branch March 31, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement all ShuffleModes in the ItemSorter
1 participant