Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix passing NULL to memcpy when unescaping a CRS value #97

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

paleolimbot
Copy link
Contributor

Found by the CRAN check: https://www.stats.ox.ac.uk/pub/bdr/memtests/gcc-UBSAN/geoarrow/tests/testthat.Rout

geoarrow.c:4843:7: runtime error: null pointer passed as argument 1, which is declared to never be null
    #0 0x7f0fcf929ecf in GeoArrowUnescapeCrs /data/gannet/ripley/R/packages/tests-gcc-SAN/geoarrow/src/geoarrow.c:4843
    #1 0x7f0fcf9e453b in geoarrow_c_schema_parse /data/gannet/ripley/R/packages/tests-gcc-SAN/geoarrow/src/r-type.c:82
    #2 0x58c2e5 in R_doDotCall /data/gannet/ripley/R/svn/R-devel/src/main/dotcode.c:757
    #3 0x652927 in bcEval_loop /data/gannet/ripley/R/svn/R-devel/src/main/eval.c:8690
    #4 0x68d632 in bcEval /data/gannet/ripley/R/svn/R-devel/src/main/eval.c:7523

@paleolimbot paleolimbot merged commit b677e84 into geoarrow:main Jun 2, 2024
9 checks passed
@paleolimbot paleolimbot deleted the fix-ubsan-strings branch June 2, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant