Update petsc solver

[rileyhales]

Remove usages of MPI and use the PETSc preonly solver insetad of richardson

Summary by CodeRabbit

• Refactor
  • Simplified the command construction logic in the RAPIDpy cleanup process for efficiency.
• Chores
  • Updated RAPIDpy package version to 2.8.0.
  • Removed Python 2 support indicators from the package metadata.

[coderabbitai]

Walkthrough

The RAPIDpy project has streamlined its operation and setup. By simplifying the rapid_cleanup function, it now uses a uniform approach for command construction, removing processor-dependent logic. Additionally, the project steps forward by marking its evolution from version 2.7.0 to 2.8.0 and shedding support for Python 2, reflecting a commitment to modern Python standards.

Changes

File	Change Summary
rapid.py	Simplified run_rapid_command in rapid_cleanup function
setup.py	Updated version to 2.8.0, removed Python 2 classifiers

🐇✨
In the meadow of code, under the sky so broad,
The RAPIDpy hops ahead, with its burden shed.
No more tangled webs of yore,
It leaps to version 2.8.0, ready to explore.
Farewell to Python 2, it whispers with glee,
As it bounds into the future, free.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bd1d2b9 and f8b83f6.

Files selected for processing (2)

• RAPIDpy/rapid.py (1 hunks)
• setup.py (2 hunks)

Files skipped from review due to trivial changes (1)

• setup.py

Additional comments: 2

RAPIDpy/rapid.py (2)

• 777-777: The change to use the Cygwin path conversion method for the local_rapid_executable_location variable is appropriate for ensuring compatibility with Windows systems using Cygwin. This adjustment ensures that the path format aligns with Cygwin's expectations, facilitating the execution of the RAPID executable in a Windows environment.
• 781-786: The removal of the conditional logic for adjusting the run_rapid_command based on the number of processors and the hardcoding of -ksp_type to 'preonly' align with the PR objectives to simplify the PETSc solver configuration and move away from MPI usages. However, this change could impact users who rely on parallel processing capabilities. It's important to ensure that documentation and release notes clearly communicate this change to users, highlighting the shift towards a simplified solver configuration and the implications for parallel processing.

Consider adding documentation or release notes to clearly communicate the changes in solver configuration and the removal of MPI-based parallel processing capabilities to users. This will help manage expectations and guide users in adapting to the new configuration.