-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added curve drawing/editing support #1026
Conversation
Thanks for this nice feature! I have spoken with @codeofsumit and we decided that it makes sense to add this as a plugin, because it increases the package size over 100kb and we want that If it is ok for you, we will setup a project |
Sure, no problem with that! |
@qpincon new repo is created, can you please create a PR there: https://github.com/geoman-io/leaflet-geoman-curve |
Thank you! |
Can we do it in following steps:
And I want to look where we need to implement API interfaces for plugins. So let us start with draw and edit ok? |
I would love to use this funcionality. @qpincon I tried to run the demo of your fork and there is the button for drawinf curves, but it doesn't work. @Falke-Design I guess this plugin wasn't implemented. I tried the demo in development branch in https://github.com/geoman-io/leaflet-geoman-curve but it doesn't work. |
@AndrejGajdos we currently stopped and never finished the development of leaflet-geoman-curve |
As discussed in #872.
If the Leaflet.curve plugin is defined, the drawing of curve is enabled (with editing, dragging, rotation).
Touch support is also handled, however not tested extensively.
Limitations:
At the moment there is not self-intersection detection for curves, and cutting the shape with the cut tool is not possible. It is a possible improvement in the future.
Let me know if you have any question.