Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing type definition #1514

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix missing type definition #1514

merged 1 commit into from
Sep 15, 2024

Conversation

m208
Copy link
Contributor

@m208 m208 commented Sep 15, 2024

Fixed missing type definition for the "name" property of the Action object, which is used as the class name for the button.

Source:

const name = typeof _action === 'string' ? _action : _action.name;
let action;
if (actions[name]) {
action = actions[name];
} else if (_action.text) {
action = _action;
} else {
return;
}
const actionNode = L.DomUtil.create(
'a',
`leaflet-pm-action ${pos} action-${name}`,
actionContainer
);

TS error:

image

Copy link
Collaborator

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@Falke-Design Falke-Design merged commit c8961ef into geoman-io:develop Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants