Skip to content

refactor

refactor #47

Triggered via push September 25, 2023 15:33
Status Success
Total duration 1m 39s
Artifacts

lints-beta.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

79 warnings
redundant closure: halo2_proofs/src/protostar/constraints/expression.rs#L325
warning: redundant closure --> halo2_proofs/src/protostar/constraints/expression.rs:325:18 | 325 | &mut |constant| Expression::Constant(constant), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Expression::Constant` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-W clippy::redundant-closure` implied by `-W clippy::all`
unused variable: `circuit3`: halo2_proofs/examples/folding.rs#L255
warning: unused variable: `circuit3` --> halo2_proofs/examples/folding.rs:255:9 | 255 | let circuit3 = MyCircuit::<pallas::Scalar, W, H>::rand(&mut rng); | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_circuit3` | = note: `#[warn(unused_variables)]` on by default
unused import: `VerificationStrategy`: halo2_proofs/examples/folding.rs#L6
warning: unused import: `VerificationStrategy` --> halo2_proofs/examples/folding.rs:6:44 | 6 | poly::{self, commitment::ParamsProver, VerificationStrategy}, | ^^^^^^^^^^^^^^^^^^^^
unused import: `TranscriptReadBuffer`: halo2_proofs/examples/folding.rs#L12
warning: unused import: `TranscriptReadBuffer` --> halo2_proofs/examples/folding.rs:12:46 | 12 | transcript::{Blake2bWrite, Challenge255, TranscriptReadBuffer, TranscriptWriterBuffer}, | ^^^^^^^^^^^^^^^^^^^^
unused import: `FromUniformBytes`: halo2_proofs/examples/folding.rs#L1
warning: unused import: `FromUniformBytes` --> halo2_proofs/examples/folding.rs:1:23 | 1 | use ff::{BatchInvert, FromUniformBytes}; | ^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
function `extract_common_simple_selector` is never used: halo2_proofs/src/protostar/keygen.rs#L404
warning: function `extract_common_simple_selector` is never used --> halo2_proofs/src/protostar/keygen.rs:404:8 | 404 | pub fn extract_common_simple_selector<F: Field>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
field `permutation_pk` is never read: halo2_proofs/src/protostar/keygen.rs#L46
warning: field `permutation_pk` is never read --> halo2_proofs/src/protostar/keygen.rs:46:16 | 25 | pub struct ProvingKey<C: CurveAffine> { | ---------- field in this struct ... 46 | pub(crate) permutation_pk: permutation::ProvingKey<C>, | ^^^^^^^^^^^^^^ | = note: `ProvingKey` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
method `traverse` is never used: halo2_proofs/src/protostar/constraints/expression.rs#L38
warning: method `traverse` is never used --> halo2_proofs/src/protostar/constraints/expression.rs:38:12 | 23 | impl<F, CV, FV, WV> Expression<F, CV, FV, WV> { | --------------------------------------------- method in this implementation ... 38 | pub fn traverse(&self, f: &mut impl FnMut(&Self)) { | ^^^^^^^^
field `num_rows` is never read: halo2_proofs/src/protostar/constraints.rs#L28
warning: field `num_rows` is never read --> halo2_proofs/src/protostar/constraints.rs:28:5 | 19 | pub struct Data<T: QueryType> { | ---- field in this struct ... 28 | num_rows: usize, | ^^^^^^^^
function `batch_commit_transparent` is never used: halo2_proofs/src/protostar/accumulator/committed.rs#L91
warning: function `batch_commit_transparent` is never used --> halo2_proofs/src/protostar/accumulator/committed.rs:91:8 | 91 | pub fn batch_commit_transparent< | ^^^^^^^^^^^^^^^^^^^^^^^^
function `lagrange_from_vec` is never used: halo2_proofs/src/poly.rs#L91
warning: function `lagrange_from_vec` is never used --> halo2_proofs/src/poly.rs:91:15 | 91 | pub(crate) fn lagrange_from_vec<F: ff::Field>(values: Vec<F>) -> Polynomial<F, LagrangeCoeff> { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
useless conversion to the same type: `std::ops::Range<usize>`: halo2_proofs/benches/commit_zk.rs#L29
warning: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/benches/commit_zk.rs:29:46 | 29 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..n_chunks) | ______________________________________________^ 30 | | .into_iter() | |____________________^ help: consider removing `.into_iter()`: `(0..n_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`
unused variable: `error`: halo2_proofs/src/protostar/accumulator.rs#L122
warning: unused variable: `error` --> halo2_proofs/src/protostar/accumulator.rs:122:13 | 122 | let error = error_vec | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` | = note: `#[warn(unused_variables)]` on by default
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sinsemilla.rs#L200
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sinsemilla.rs:200:30 | 200 | assert!(num_words <= piece_max_num_words as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `piece_max_num_words` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/util.rs#L113
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/util.rs:113:31 | 113 | let carry = sum.map(|sum| (sum >> 32) as u64); | ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L180
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57 | 180 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L264
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57 | 264 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L56
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34 | 56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L50
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34 | 50 | + SUBREGION_3_WORD * (word_idx - 49) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L43
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47 | 43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L786
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65 | 786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)), | ^^^^^^^^^^^^ help: try: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L114
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13 | 114 | (idx as usize) * SUBREGION_MAIN_WORD | ^^^^^^^^^^^^^^ help: try: `idx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L51
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:51:25 | 51 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L25
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:25:25 | 25 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/pow5.rs#L513
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:513:77 | 513 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/pow5.rs#L473
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:473:73 | 473 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/pow5.rs#L447
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:447:62 | 447 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/mul_fixed.rs#L397
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:397:42 | 397 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/mul_fixed.rs#L392
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:392:37 | 392 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/mul_fixed.rs#L375
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:375:68 | 375 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/benches/poseidon.rs#L138
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/poseidon.rs:138:25 | 138 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L147
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:147:35 | 147 | let mut proof_fs = File::open(&proof_path).expect("couldn't load sha256_proof"); | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L143
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:143:37 | 143 | let mut file = File::create(&proof_path).expect("Failed to create sha256_proof"); | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L131
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:131:19 | 131 | if File::open(&proof_path).is_err() { | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L104
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:104:32 | 104 | let params_fs = File::open(&params_path).expect("couldn't load sha256_params"); | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L98
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:98:37 | 98 | let mut file = File::create(&params_path).expect("Failed to create sha256_params"); | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L93
warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:93:19 | 93 | if File::open(&params_path).is_err() { | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sinsemilla.rs#L200
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sinsemilla.rs:200:30 | 200 | assert!(num_words <= piece_max_num_words as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `piece_max_num_words` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/util.rs#L113
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/util.rs:113:31 | 113 | let carry = sum.map(|sum| (sum >> 32) as u64); | ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L180
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57 | 180 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L264
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57 | 264 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L56
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34 | 56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L50
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34 | 50 | + SUBREGION_3_WORD * (word_idx - 49) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L43
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47 | 43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L786
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65 | 786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)), | ^^^^^^^^^^^^ help: try: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L114
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13 | 114 | (idx as usize) * SUBREGION_MAIN_WORD | ^^^^^^^^^^^^^^ help: try: `idx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L51
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:51:25 | 51 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L25
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:25:25 | 25 | val.pow_vartime(&[5]) | ^^^^ help: change this to: `[5]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/pow5.rs#L513
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:513:77 | 513 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/pow5.rs#L473
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:473:73 | 473 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/poseidon/pow5.rs#L447
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/poseidon/pow5.rs:447:62 | 447 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect(); | ^^^^^^^^^^^^^ help: change this to: `config.alpha` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/mul_fixed.rs#L397
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:397:42 | 397 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/mul_fixed.rs#L392
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:392:37 | 392 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/mul_fixed.rs#L375
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/mul_fixed.rs:375:68 | 375 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0])); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:220:45 | 220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:217:42 | 217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:200:53 | 200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:72:53 | 72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:65:38 | 65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the borrowed expression implements the required traits: halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits --> halo2_gadgets/src/ecc/chip/constants.rs:52:57 | 52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]); | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
redundant closure: halo2_proofs/src/protostar/constraints/expression.rs#L325
warning: redundant closure --> halo2_proofs/src/protostar/constraints/expression.rs:325:18 | 325 | &mut |constant| Expression::Constant(constant), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Expression::Constant` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-W clippy::redundant-closure` implied by `-W clippy::all`
function `extract_common_simple_selector` is never used: halo2_proofs/src/protostar/keygen.rs#L404
warning: function `extract_common_simple_selector` is never used --> halo2_proofs/src/protostar/keygen.rs:404:8 | 404 | pub fn extract_common_simple_selector<F: Field>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
field `permutation_pk` is never read: halo2_proofs/src/protostar/keygen.rs#L46
warning: field `permutation_pk` is never read --> halo2_proofs/src/protostar/keygen.rs:46:16 | 25 | pub struct ProvingKey<C: CurveAffine> { | ---------- field in this struct ... 46 | pub(crate) permutation_pk: permutation::ProvingKey<C>, | ^^^^^^^^^^^^^^ | = note: `ProvingKey` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
method `traverse` is never used: halo2_proofs/src/protostar/constraints/expression.rs#L38
warning: method `traverse` is never used --> halo2_proofs/src/protostar/constraints/expression.rs:38:12 | 23 | impl<F, CV, FV, WV> Expression<F, CV, FV, WV> { | --------------------------------------------- method in this implementation ... 38 | pub fn traverse(&self, f: &mut impl FnMut(&Self)) { | ^^^^^^^^
field `num_rows` is never read: halo2_proofs/src/protostar/constraints.rs#L28
warning: field `num_rows` is never read --> halo2_proofs/src/protostar/constraints.rs:28:5 | 19 | pub struct Data<T: QueryType> { | ---- field in this struct ... 28 | num_rows: usize, | ^^^^^^^^
function `batch_commit_transparent` is never used: halo2_proofs/src/protostar/accumulator/committed.rs#L91
warning: function `batch_commit_transparent` is never used --> halo2_proofs/src/protostar/accumulator/committed.rs:91:8 | 91 | pub fn batch_commit_transparent< | ^^^^^^^^^^^^^^^^^^^^^^^^
function `lagrange_from_vec` is never used: halo2_proofs/src/poly.rs#L91
warning: function `lagrange_from_vec` is never used --> halo2_proofs/src/poly.rs:91:15 | 91 | pub(crate) fn lagrange_from_vec<F: ff::Field>(values: Vec<F>) -> Polynomial<F, LagrangeCoeff> { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused variable: `error`: halo2_proofs/src/protostar/accumulator.rs#L122
warning: unused variable: `error` --> halo2_proofs/src/protostar/accumulator.rs:122:13 | 122 | let error = error_vec | ^^^^^ help: if this is intentional, prefix it with an underscore: `_error` | = note: `#[warn(unused_variables)]` on by default
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/