Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set site settings in swagger_ui so it function correctly. #8582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ianwallen
Copy link
Contributor

@ianwallen ianwallen commented Dec 24, 2024

Prior to this fix, the swagger ui for applying site settings was not working.

Before the swagger ui would look like the following

image

And generate the following error

image

After, it will look like the following (with some examples.)

image

And when valid values are supplied, it will generate the following results

image

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@ianwallen ianwallen added api change Indicate a change in the API backport 4.2.x labels Dec 24, 2024
@ianwallen ianwallen added this to the 4.4.7 milestone Dec 24, 2024
@ianwallen ianwallen force-pushed the fix_save_setting_swagger_ui branch from 37e2faf to adc73ff Compare December 24, 2024 19:04
Prior to this fix, the swagger ui for applying site settings was not working.
@ianwallen ianwallen force-pushed the fix_save_setting_swagger_ui branch from adc73ff to c9e0ae9 Compare December 25, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Indicate a change in the API backport 4.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant